-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHNL-17243: Handle lifecycle events from JS #270
Conversation
I'm seeing the PR for this is merged. Are you able to get the events over the JS bridge? |
nvm I'm seeing the demo now and it does look like you are indeed receiving those! Nice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
At this moment, while testing, the SDK is still receiving the outdated |
@timstephens-k is there a branch with the changed event names that Belle can use to test locally? Is it this? |
found this branch to test on and confirmed it is working with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Description
Calls
presentIAF()
when receivingformWillAppear
and created new methoddismissIAF()
for receiving theformDisappeared
case.Check List
Manual Test Plan
In this mini demo I added some print statements to see when the different messages were being received. You can also tell the webview is dismissed when the form is dismissed as the rest of the app is interactable again/you can navigate away -- as well as reopen the form, etc.
lifecycle.events.mov
Supporting Materials