Suggestions branch #272
Merged
Suggestions branch #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
ab1470
force-pushed
the
ab/IAF-js-lifecycle-events-suggestion
branch
from
dd377ea to
c58cf35
Compare
| } | ||
|
|
||
| group.addTask { [weak self] in | ||
| await withCheckedContinuation { continuation in |
There was a problem hiding this comment.
ooooo this is neat, didn't know about this before, but after reading up on it + testing it out a bit, this makes sense given the cadence of when formWillAppear is to be emitted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggestion PR for
bl/IAF-js-lifecycle-events. See my comment on that PR.*note: I did not test this. It may require some changes and/or refinement