Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip doesn't take className well #1399

Closed
eheslouisKlee opened this issue Jun 20, 2017 · 2 comments
Closed

Tooltip doesn't take className well #1399

eheslouisKlee opened this issue Jun 20, 2017 · 2 comments
Assignees
@c3dr0x
Labels
Bug Waiting for Release
Milestone
2.2.0

Comments

@eheslouisKlee
Copy link

Current behaviour

When passing a className to Tooltip, the className is not well construted. A space is missing between the props.ClassName and the rest of the className.

capturetooltip2

capturetooltip1

Expected behaviour

The className should be as following:

capturetooltipgood1

Versions

Focus-core: 2.1.1
Focus-components: git://github.com/KleeGroup/focus-components.git#add-rgaa-updated
c3dr0x added a commit that referenced this issue Jun 21, 2017
@c3dr0x
Tooltip doesn't take className well
a8d47b0 
Fix issue #1399

Generated classname concat both custom and own classes without space between em
@c3dr0x c3dr0x mentioned this issue Jun 21, 2017
Merged
@Hartorn Hartorn added the Bug label Jun 21, 2017
@Hartorn Hartorn added this to the Short term release milestone Jun 21, 2017
Hartorn pushed a commit that referenced this issue Jun 27, 2017
@c3dr0x @Hartorn
Tooltip doesn't take className well
23b6f22 
Fix issue #1399
@JohnnP JohnnP modified the milestones: 2.2.0, Short term release Jul 7, 2017
@JohnnP
Copy link
Contributor

JohnnP commented Jul 7, 2017

Fix with PR #1400

@JohnnP JohnnP closed this as completed Jul 7, 2017
@JohnnP JohnnP reopened this Jul 7, 2017
@Hartorn
Copy link
Contributor

Hartorn commented Nov 15, 2017

Delivered in 2.2.0

@Hartorn Hartorn closed this as completed Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c3dr0x c3dr0x

Labels
Bug Waiting for Release
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
4 participants
@c3dr0x @Hartorn @JohnnP @eheslouisKlee