Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip doesn't take className well #1400

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Tooltip doesn't take className well #1400

merged 1 commit into from
Jun 27, 2017

Conversation

c3dr0x
Copy link
Contributor

@c3dr0x c3dr0x commented Jun 21, 2017

Fix issue #1399

Generated classname concat both custom and own classes without space between em

@c3dr0x c3dr0x self-assigned this Jun 21, 2017
@c3dr0x c3dr0x requested a review from Hartorn June 21, 2017 16:02
Hartorn
Hartorn reviewed Jun 21, 2017
View reviewed changes
Copy link
Contributor

@Hartorn Hartorn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it would be better to simply always add a space in the return of this.buildClassname in the interpolated string. Seems simpler and clearer to me (although the fix should be working)

@c3dr0x c3dr0x added this to the Short term release milestone Jun 21, 2017
@c3dr0x c3dr0x changed the base branch from master to develop June 22, 2017 07:47
@Hartorn Hartorn force-pushed the fix-tooltip-classname branch from 4b10cf3 to 23b6f22 Compare June 27, 2017 15:28
@Hartorn Hartorn merged commit f9ad199 into develop Jun 27, 2017
@Hartorn Hartorn deleted the fix-tooltip-classname branch June 27, 2017 15:51
@JohnnP JohnnP mentioned this pull request Jul 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hartorn Hartorn Hartorn approved these changes

Assignees

@c3dr0x c3dr0x

Labels
Bug Waiting for Release
Projects
None yet
Milestone
Short term release
Development

Successfully merging this pull request may close these issues.
2 participants
@c3dr0x @Hartorn