-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup GitHub actions to build and publish sdist and wheels #1082
Conversation
7fb4f78
to
3abb1b3
Compare
9600a87
to
88ef54a
Compare
ed18e96
to
4986ebf
Compare
dde05d0
to
b132609
Compare
The wheels are ready to review in the artifacts section of any given job. Upon GitHub release, they shall be uploaded to PyPI. |
@hroncok I've created a pypi API token and added it as a secret named PIPY_API_KEY use token as username and this API key as password. I looked all over but couldn't find a way to allow anyone but the repo owner to add secrets. |
Thanks. Amended. Is this good to merge and shall we release rc6 as a followup? |
Ehm, one more thing. PIPY_API_KEY should have probably been PYPI_API_KEY, right? |
Yes, except github's formatting mangled my message - the username needs to be |
No, actually, it's correct as PIPY - I typoed it. Looks like it's impossible to rename. |
I now added a second secret with the correct spelling |
Thanks. So we should be good now. The only way to test is is to actually use it. |
Okay, from my pov we're good to merge. Feel free to do so if you feel the same way. |
If you want I can also make a pypi test repo API key |
I don't think that is necessary, better to squat the name sooner than later. |
I'm working to prep the PR with rc6 with chnagelog. |
|
I'll try manually uploading one with the same key to check |
Try the sdist probably. |
I tried it and it says "The name 'Printrun' isn't allowed. See https://pypi.org/help/#project-name for more information." |
And I know why. What is your PyPI username? |
My PyPI username is "kliment" |
So the manual upload gave a different error than the automated one, suggesting we're not correctly setting the twine credentials. I'll create a new api key just for this and update the secrets. |
OK. The good news is nobody will claim the printrun name before you do, so we don't need to figure this out immediately. |
So it works correctly now, but we can't upload because the name is locked. |
Followups: