Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup GitHub actions to build and publish sdist and wheels #1082

Merged
merged 1 commit into from
Aug 2, 2020
Merged

Conversation

hroncok
Copy link
Collaborator

@hroncok hroncok commented Jul 26, 2020

Followups:

@hroncok hroncok force-pushed the actions branch 3 times, most recently from 7fb4f78 to 3abb1b3 Compare July 26, 2020 21:45
@hroncok hroncok changed the title Setup GitHub actions to build wheel Setup GitHub actions to build and publish sdist and manylinux wheels Jul 26, 2020
@hroncok hroncok force-pushed the actions branch 3 times, most recently from 9600a87 to 88ef54a Compare July 26, 2020 22:03
@hroncok hroncok changed the title Setup GitHub actions to build and publish sdist and manylinux wheels Setup GitHub actions to build and publish sdist and wheels Jul 26, 2020
@hroncok hroncok force-pushed the actions branch 2 times, most recently from ed18e96 to 4986ebf Compare July 26, 2020 22:06
@hroncok hroncok force-pushed the actions branch 9 times, most recently from dde05d0 to b132609 Compare July 27, 2020 05:58
@hroncok
Copy link
Collaborator Author

hroncok commented Jul 27, 2020

The wheels are ready to review in the artifacts section of any given job. Upon GitHub release, they shall be uploaded to PyPI.
@kliment Could you please store your PyPI credentials (PYPI_USERNAME, PYPI_PASSWORD) (or alternatively, give me the rights to store mine (I assume admin to the repo))? Once merged, we could release rc6 to actually test it and later we should update the installation instructions in README.

@hroncok hroncok marked this pull request as ready for review July 27, 2020 06:07
@kliment
Copy link
Owner

kliment commented Aug 2, 2020

@hroncok I've created a pypi API token and added it as a secret named PIPY_API_KEY use token as username and this API key as password. I looked all over but couldn't find a way to allow anyone but the repo owner to add secrets.

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

Thanks. Amended. Is this good to merge and shall we release rc6 as a followup?

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

Ehm, one more thing. PIPY_API_KEY should have probably been PYPI_API_KEY, right?

@kliment
Copy link
Owner

kliment commented Aug 2, 2020

Yes, except github's formatting mangled my message - the username needs to be __token__

@kliment
Copy link
Owner

kliment commented Aug 2, 2020

Ehm, one more thing. PIPY_API_KEY should have probably been PYPI_API_KEY, right?

No, actually, it's correct as PIPY - I typoed it. Looks like it's impossible to rename.

@kliment
Copy link
Owner

kliment commented Aug 2, 2020

I now added a second secret with the correct spelling

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

Thanks. So we should be good now. The only way to test is is to actually use it.

@kliment
Copy link
Owner

kliment commented Aug 2, 2020

Okay, from my pov we're good to merge. Feel free to do so if you feel the same way.

@kliment
Copy link
Owner

kliment commented Aug 2, 2020

If you want I can also make a pypi test repo API key

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

If you want I can also make a pypi test repo API key

I don't think that is necessary, better to squat the name sooner than later.

@hroncok hroncok merged commit fa27d74 into master Aug 2, 2020
@hroncok hroncok deleted the actions branch August 2, 2020 15:37
@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

I'm working to prep the PR with rc6 with chnagelog.

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

#1085

@hroncok hroncok mentioned this pull request Aug 2, 2020
4 tasks
@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

Run twine upload dist/*
Uploading distributions to https://upload.pypi.org/legacy/
Uploading Printrun-2.0.0rc6.tar.gz

  0%|          | 0.00/478k [00:00<?, ?B/s]
  2%|▏         | 8.00k/478k [00:00<00:08, 56.1kB/s]
 59%|█████▊    | 280k/478k [00:00<00:02, 79.5kB/s] 
100%|██████████| 478k/478k [00:00<00:00, 1.16MB/s]
NOTE: Try --verbose to see response content.
HTTPError: 403 Forbidden from https://upload.pypi.org/legacy/
Invalid or non-existent authentication information. See https://pypi.org/help/#invalid-auth for more information.

@kliment
Copy link
Owner

kliment commented Aug 2, 2020

I'll try manually uploading one with the same key to check

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

Try the sdist probably.

@kliment
Copy link
Owner

kliment commented Aug 2, 2020

I tried it and it says "The name 'Printrun' isn't allowed. See https://pypi.org/help/#project-name for more information."

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

And I know why. What is your PyPI username?

@kliment
Copy link
Owner

kliment commented Aug 2, 2020

My PyPI username is "kliment"

@kliment
Copy link
Owner

kliment commented Aug 2, 2020

So the manual upload gave a different error than the automated one, suggesting we're not correctly setting the twine credentials. I'll create a new api key just for this and update the secrets.

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

OK. The good news is nobody will claim the printrun name before you do, so we don't need to figure this out immediately.

pypi/support#529

@kliment
Copy link
Owner

kliment commented Aug 2, 2020

2020-08-02T20:07:53.3841762Z The name 'Printrun' isn't allowed. See https://pypi.org/help/#project-name for more information.

So it works correctly now, but we can't upload because the name is locked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants