Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Printrun 2.0.0rc6 #1085

Merged
merged 1 commit into from
Aug 2, 2020
Merged

Release Printrun 2.0.0rc6 #1085

merged 1 commit into from
Aug 2, 2020

Conversation

hroncok
Copy link
Collaborator

@hroncok hroncok commented Aug 2, 2020

No description provided.

@hroncok hroncok merged commit cc30bbc into kliment:master Aug 2, 2020
@hroncok hroncok deleted the rc6 branch August 2, 2020 16:13
@kliment
Copy link
Owner

kliment commented Aug 2, 2020

One thing I'm concerned about with the pypi wheels is that the os names need to have a particular pattern to be accepted to pypi but they are currently named after the github action runner system name

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

they are currently named after the github action runner system name

I see Printrun-2.0.0rc6-cp38-cp38-win_amd64.whl, Printrun-2.0.0rc6-cp38-cp38-linux_x86_64.whl etc. This should be alright.

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

However, is should be manylinux, not linux :(

Let's figure that out after we figure out the credentials issue: #1082 (comment)

@kliment
Copy link
Owner

kliment commented Aug 2, 2020

the source distribution is missing the filename too as far as I can see - it's just called sdist, and the macos buid is called macos-latest, whereas it should be something like macosx_10_15_x86_64. See here for naming convention examples.

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

That is just the zip with possibly multiple files.

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

I've opened RalfG/python-wheels-manylinux-build#24 for the manylinux thing.

@kliment
Copy link
Owner

kliment commented Aug 2, 2020

For some reason windows build for 3.6 produces a file called Printrun-2.0.0rc6-cp38-cp38-win_amd64.whl

@kliment
Copy link
Owner

kliment commented Aug 2, 2020

Similarly the manylinux one produces "Binary wheel 'Printrun-2.0.0rc6-cp36-cp36m-linux_x86_64.whl' has an unsupported platform tag 'linux_x86_64'."

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

Yes, the manylinux are RalfG/python-wheels-manylinux-build#24 and #1086

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

For some reason windows build for 3.6 produces a file called Printrun-2.0.0rc6-cp38-cp38-win_amd64.whl

All the Windows builds are 3.8 in fact :/

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

Here: #1087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants