Only upload audited wheels / use manylinux2014 #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroncok
force-pushed
the
manylinux_only
branch
2 times, most recently
from
253717e to
2df38ea
Compare
hroncok
changed the title
kliment
reviewed
Aug 20, 2020
| @@ -21,19 +21,19 @@ jobs: | |||
| run: | | |||
| python -m pip install --upgrade pip setuptools wheel twine | |||
| - name: Build manylinux Python wheels | |||
| uses: RalfG/python-wheels-manylinux-build@v0.3-manylinux1_x86_64 | |||
| uses: RalfG/python-wheels-manylinux-build@v0.3.1-manylinux2014_x86_64 | |||
| with: | |||
| python-versions: 'cp36-cp36m cp37-cp37m cp38-cp38' | |||
There was a problem hiding this comment.
Is it correct that 36 and 37 have an m but 38 does not?
There was a problem hiding this comment.
Indeed it is. See https://docs.python.org/3.8/whatsnew/3.8.html#build-and-c-api-changes
Default sys.abiflags became an empty string: the m flag for pymalloc became useless (builds with and without pymalloc are ABI compatible) and so has been removed.
|
Okay great - I'll merge this then |
|
We should be able to upload the wheels to PyPI by releasing a new rc. |
|
Yep. Go ahead and do that when you have a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.