-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added broker and trigger tests to keda reconciler tests #3819
Added broker and trigger tests to keda reconciler tests #3819
Conversation
Signed-off-by: Neeraj Nagure <nagureneeraj@gmail.com>
Hi @NeerajNagure. Thanks for your PR. I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3819 +/- ##
=============================================
- Coverage 73.90% 49.72% -24.18%
=============================================
Files 100 246 +146
Lines 3407 14819 +11412
Branches 288 0 -288
=============================================
+ Hits 2518 7369 +4851
- Misses 716 6695 +5979
- Partials 173 755 +582
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Neeraj Nagure <nagureneeraj@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NeerajNagure, left a few cleanup comments
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@pierDipi I think so the tests that are left now in my changes are broker tests.How can I add the trigger tests then? |
@NeerajNagure broker tests are also trigger tests, so the PR looks good to me /lgtm /assign @Cali0707 |
/ok-to-test |
Signed-off-by: Neeraj Nagure <nagureneeraj@gmail.com>
…Nagure/eventing-kafka-broker into broker/trigger-keda-tests updated broker and trigger tests
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NeerajNagure The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@NeerajNagure don't worry about the failing tests - those are unrelated to your changes. It looks like our CI is having issues this morning |
@Cali0707 I have made the changes and removed -run=kafkasource flag test |
/retest-required |
2 similar comments
/retest-required |
/retest-required |
@Cali0707 there is this error in keda tests |
@Cali0707 can you help @NeerajNagure ? |
/retest |
Same error
|
I'll look into it today 👍 |
Hey @NeerajNagure I think I found the problem that you are seeing in your tests - the You'll notice that this will leave you with two keys that seemingly do the same thing:
We should remove the Hopefully this makes sense, if you have any questions please feel free to ask! |
Signed-off-by: Neeraj Nagure <nagureneeraj@gmail.com>
@Cali0707 thanks for the help I have made the changes |
/retest-required |
1 similar comment
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @NeerajNagure sorry for missing this earlier, I think we also need something like
kubectl apply -f ./test/e2e_new/config/features.yaml |
Signed-off-by: Neeraj Nagure <nagureneeraj@gmail.com>
/retest-required |
@NeerajNagure looks like these tests caught a bug! Would you be interested in investigating it? If you're not sure, I'm happy to try and investigate and resolve the bug myself as well |
@Cali0707 I couldnt understand the bug so you please go ahead in investigating the bug |
Hey @NeerajNagure I think my PR linked above should fix the problems here - we just need to merge that into eventing, and then update the dependencies here. If you want to, it would be great if you review the PR in eventing! |
/retest-required |
/test reconciler-tests-keda |
@Cali0707 I think so we are getting this error |
/test reconciler-tests-keda |
@NeerajNagure: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This Pull Request is stale because it has been open for 90 days with |
Fixes #3814
Proposed Changes
Added broker and trigger tests to keda reconciler tests so as to test them in keda environment.
🎁 Added broker and trigger tests