fix: trigger tests set annotations correctly now

[Cali0707]

Locally, this patch fixes the bug seen in knative-extensions/eventing-kafka-broker#3819. It looks like we weren't setting the annotation correctly on the trigger in the tests, so the ordered config was not applied.

Proposed Changes

• Set the trigger annotation properly

[Cali0707]

/cc @pierDipi @creydr @NeerajNagure

[knative-prow]

@Cali0707: GitHub didn't allow me to request PR reviews from the following users: NeerajNagure.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @pierDipi @creydr @NeerajNagure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Cali0707]

For context, the relevant part of the yaml template is:

  {{ if .annotations }}
  annotations:
  {{ range $key, $value := .annotations }}
    {{ $key }}: {{ $value }}
  {{ end }}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.18%. Comparing base (7e1c082) to head (30bf876).
Report is 29 commits behind head on main.

❗ Current head 30bf876 differs from pull request most recent head e2bc2ff. Consider uploading reports for the commit e2bc2ff to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7887      +/-   ##
==========================================
- Coverage   69.22%   69.18%   -0.04%     
==========================================
  Files         339      341       +2     
  Lines       19494    15816    -3678     
==========================================
- Hits        13494    10943    -2551     
+ Misses       5337     4200    -1137     
- Partials      663      673      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[knative-prow]

@NeerajNagure: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pierDipi]

/lgtm
/approve

[creydr]

/lgtm

[pierDipi]

/test reconciler-tests

[Cali0707]

/cc @pierDipi @creydr @Leo6Leo

[Cali0707]

/cc @pierDipi

[pierDipi]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr, NeerajNagure, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [Cali0707,creydr,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pierDipi]

/retest-required

[Cali0707]

wait.go:200: test-zqexebpt/customname condition is {"type":"Ready","status":"False","lastTransitionTime":"2024-05-07T16:48:18Z","reason":"TrustBundlePropagation","message":"failed to create ConfigMap test-zqexebpt/knative-eventing-bundlekne-bundle: configmaps \"knative-eventing-bundlekne-bundle\" already exists"}

Trust bundle issues 😞

/retest-required

[Cali0707]

/retest-required

Trust bundles again :(

[maschmid]

/cherry-pick release-1.14

[knative-prow-robot]

@maschmid: new pull request created: #8053

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.