-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: trigger tests set annotations correctly now #7887
Conversation
Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707: GitHub didn't allow me to request PR reviews from the following users: NeerajNagure. Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
For context, the relevant part of the yaml template is: {{ if .annotations }}
annotations:
{{ range $key, $value := .annotations }}
{{ $key }}: {{ $value }}
{{ end }} |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7887 +/- ##
==========================================
- Coverage 69.22% 69.18% -0.04%
==========================================
Files 339 341 +2
Lines 19494 15816 -3678
==========================================
- Hits 13494 10943 -2551
+ Misses 5337 4200 -1137
- Partials 663 673 +10 ☔ View full report in Codecov by Sentry. |
@NeerajNagure: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test reconciler-tests |
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
/cc @pierDipi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, creydr, NeerajNagure, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
Trust bundle issues 😞 /retest-required |
/retest-required Trust bundles again :( |
/cherry-pick release-1.14 |
@maschmid: new pull request created: #8053 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Locally, this patch fixes the bug seen in knative-extensions/eventing-kafka-broker#3819. It looks like we weren't setting the annotation correctly on the trigger in the tests, so the ordered config was not applied.
Proposed Changes