Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.14] fix: trigger tests set annotations correctly now #8053

Open
wants to merge 3 commits into
base: release-1.14
Choose a base branch
from
Open

[release-1.14] fix: trigger tests set annotations correctly now #8053

wants to merge 3 commits into from

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #7887

@Cali0707 @knative-prow-robot
fix: trigger tests set annotations correctly now
d6c4d11 
Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707 @knative-prow-robot
fix: trigger dependencies are set correctly in test now
e1e673d 
Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707 @knative-prow-robot
fix trigger template
fd3b48b 
Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow-robot knative-prow-robot mentioned this pull request Jun 27, 2024
Merged
@knative-prow knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Jun 27, 2024
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 27, 2024
matzew
matzew approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@matzew
Copy link
Member

matzew commented Jul 15, 2024

/test reconciler-tests

1 similar comment
@Cali0707
Copy link
Member

/test reconciler-tests

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 23, 2024

@knative-prow-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests_eventing_release-1.14 fd3b48b link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knative-prow-robot @matzew @Cali0707