fixing bug in name of Solender to avoid CLA troubles, is fixing … #1147
Conversation
…the triger subscriber namespace bug in case the subscriber has a different namespace from the trigger
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabo1208 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
knative-prow
bot
added
the
size/M
|
@gabo1208 in the pr title, can you fix the spelling of my last name? It's "Solender" :) |
gabo1208
changed the title
|
haha sure thing! My bad, now it's fine :) |
|
Glad this is getting merged, I've been running a fork in prod for a few weeks now 😆 |
Codecov Report
@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
- Coverage 74.18% 74.14% -0.04%
==========================================
Files 44 44
Lines 3304 3299 -5
==========================================
- Hits 2451 2446 -5
Misses 764 764
Partials 89 89
|
|
Yeah sometimes CLA can be a pain, but lets get this done :) with luck maybe today we'll have the approvals |
|
Saw the codecov failed, those lines are tested by the unit tests I added. Not sure why codecov missed it. The 2 unit tests I added check the not defined path and different namespaces path. |
| Key: testKey, | ||
| Objects: []runtime.Object{ | ||
| ReadyBroker(config), | ||
| makeSubscriberAddressableAsUnstructured(), |
There was a problem hiding this comment.
This function https://github.com/knative-sandbox/eventing-rabbitmq/pull/1147/files#diff-c5ee2c23a8a6dd4c7aa3e6620d57f2bfd00a6b37dd072ade8bfd386dd4952d21L1406 populates a namespace. Therefor the codecoverage is not being covered in the line specified by codecov.
There was a problem hiding this comment.
…his should be good enough to pass
|
/lgtm |
|
/retest |
|
/cherry-pick release-1.10 |
|
/cherry-pick release-1.9 |
|
@gabo1208: new pull request created: #1180 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@gabo1208: new pull request created: #1181 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
/kind bug
Fixes #1117
this PR is from @erictg to avoid getting this stale because of the CLA errors