Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed cleanup logic to rabbit connections #778

Merged

Conversation

gabo1208
Copy link
Contributor

@gabo1208 gabo1208 commented May 19, 2022

It was hanging when a connection was closed and its associated channel close method was called.
More details on this issue

Changes

  • 🐛 Fixed bug where the broker ingress was not reconnecting after the connection or channel with RabbitMQ was closed
  • 🧹 Small refactor to rabbit setup pkg

/kind bug

Fixes #764

Release Note

- 🐛 Fixed bug where the broker ingress was not reconnecting after the connection or channel with RabbitMQ was closed

…a connection was closed an its associated channel close method was called
@knative-prow knative-prow bot added kind/bug Categorizes issue or PR as related to a bug. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 19, 2022
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #778 (866487a) into main (64ec508) will increase coverage by 0.06%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
+ Coverage   75.27%   75.34%   +0.06%     
==========================================
  Files          39       39              
  Lines        2621     2620       -1     
==========================================
+ Hits         1973     1974       +1     
+ Misses        583      581       -2     
  Partials       65       65              
Impacted Files Coverage Δ
pkg/rabbit/setup.go 58.00% <75.00%> (+8.98%) ⬆️
pkg/rabbit/message.go 68.90% <0.00%> (-2.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64ec508...866487a. Read the comment docs.

@gabo1208 gabo1208 changed the title fixed cleanup logic to rabbit connections, cause it was hanging when … fixed cleanup logic to rabbit connections May 24, 2022
Copy link
Contributor

@gab-satchi gab-satchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2022
@knative-prow
Copy link

knative-prow bot commented May 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gab-satchi, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gab-satchi,gabo1208]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 3645913 into knative-extensions:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Crashing ingress and dispatcher pods when connections are disrupted in a 3 node cluster
2 participants