-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed cleanup logic to rabbit connections #778
fixed cleanup logic to rabbit connections #778
Conversation
…a connection was closed an its associated channel close method was called
Codecov Report
@@ Coverage Diff @@
## main #778 +/- ##
==========================================
+ Coverage 75.27% 75.34% +0.06%
==========================================
Files 39 39
Lines 2621 2620 -1
==========================================
+ Hits 1973 1974 +1
+ Misses 583 581 -2
Partials 65 65
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gab-satchi, gabo1208 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It was hanging when a connection was closed and its associated channel close method was called.
More details on this issue
Changes
/kind bug
Fixes #764
Release Note