Split apart defaulting and validation webhooks #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
mattmoor
force-pushed
the
split-webhook
branch
from
2d91f2e to
3550c6d
Compare
knative-prow-robot
added
size/XL
mattmoor
commented
Nov 14, 2019
mattmoor
force-pushed
the
split-webhook
branch
from
3550c6d to
f23a08b
Compare
mattmoor
commented
Nov 15, 2019
mattmoor
force-pushed
the
split-webhook
branch
from
f23a08b to
28b0700
Compare
mattmoor
commented
Nov 15, 2019
mattmoor
force-pushed
the
split-webhook
branch
from
28b0700 to
8f889bb
Compare
|
/lgtm 😬 I have so much to update in my forks of this controller. |
|
@n3wscott me too 😅 |
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: knative/pkg#848
/hold
until upstream PR lands.