Split the resource semantic webhooks into separate AdmissionControllers #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
do-not-merge/hold
knative-prow-robot
added
size/XXL
|
This also removes the long-deprecated |
mattmoor
added a commit
to mattmoor/sample-controller
that referenced
this pull request
Nov 5, 2019
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 5, 2019
vagababov
reviewed
Nov 5, 2019
| ctx = apis.WithUserInfo(ctx, &req.UserInfo) | ||
|
|
||
| // None of the validators will accept a nil value for newObj. | ||
| if newObj == nil { |
There was a problem hiding this comment.
This should be moved quite a lot up. No reason to deal with deserialization of the oldObj.
There was a problem hiding this comment.
This is largely copy/pasta, so I'd rather leave it for a follow-up cleanup pass.
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 6, 2019
mattmoor
added a commit
to mattmoor/eventing
that referenced
this pull request
Nov 6, 2019
mattmoor
force-pushed
the
split-webhook
branch
from
3f9bcd4 to
21993fe
Compare
mattmoor
added a commit
to mattmoor/eventing
that referenced
this pull request
Nov 6, 2019
mattmoor
added a commit
to mattmoor/eventing
that referenced
this pull request
Nov 6, 2019
mattmoor
added a commit
to mattmoor/eventing
that referenced
this pull request
Nov 6, 2019
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 6, 2019
mattmoor
added a commit
to mattmoor/eventing
that referenced
this pull request
Nov 6, 2019
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 6, 2019
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
hold can be removed ? |
mattmoor
force-pushed
the
split-webhook
branch
from
21993fe to
f4b7677
Compare
mattmoor
force-pushed
the
split-webhook
branch
from
4e5f033 to
492ed28
Compare
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 14, 2019
mattmoor
added a commit
to mattmoor/eventing
that referenced
this pull request
Nov 14, 2019
mattmoor
added a commit
to mattmoor/sample-controller
that referenced
this pull request
Nov 14, 2019
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 14, 2019
vagababov
reviewed
Nov 15, 2019
mattmoor
force-pushed
the
split-webhook
branch
from
492ed28 to
47c8758
Compare
mattmoor
added a commit
to mattmoor/sample-controller
that referenced
this pull request
Nov 15, 2019
By combining our validation logic into our mutating webhook we were previously allowing for mutating webhooks evaluated after our own to modify our resources into invalid shapes. There are no guarantees around ordering of mutating webhooks (that I could find), so the only way to remedy this properly is to split apart the two into separate webhook configurations: - `defaulting`: which runs during the mutating admission webhook phase - `validation`: which runs during the validating admission webhook phase. The diagram in [this post](https://kubernetes.io/blog/2019/03/21/a-guide-to-kubernetes-admission-controllers/) is very helpful in illustrating the flow of webhooks. Fixes: knative#847
mattmoor
force-pushed
the
split-webhook
branch
from
47c8758 to
dcfbe32
Compare
|
The following is the coverage report on the affected files.
|
mattmoor
added a commit
to mattmoor/sample-controller
that referenced
this pull request
Nov 15, 2019
|
/lgtm This is gonna fix some weird bugs. |
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
mattmoor
added a commit
to mattmoor/serving
that referenced
this pull request
Nov 15, 2019
mattmoor
added a commit
to mattmoor/eventing
that referenced
this pull request
Nov 15, 2019
mattmoor
added a commit
to mattmoor/sample-controller
that referenced
this pull request
Nov 15, 2019
knative-prow-robot
pushed a commit
to knative-extensions/sample-controller
that referenced
this pull request
Nov 15, 2019
knative-prow-robot
pushed a commit
to knative/eventing
that referenced
this pull request
Nov 15, 2019
knative-prow-robot
pushed a commit
to knative/serving
that referenced
this pull request
Nov 15, 2019
imjasonh
added a commit
to imjasonh/pkg
that referenced
this pull request
Mar 22, 2021
`NewAdmissionController` was moved to `resourcesemantics/validation` in knative#848 and this doc wasn't updated.
knative-prow-robot
pushed a commit
that referenced
this pull request
Mar 30, 2021
`NewAdmissionController` was moved to `resourcesemantics/validation` in #848 and this doc wasn't updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By combining our validation logic into our mutating webhook we were previously allowing for mutating webhooks evaluated after our own to modify our resources into invalid shapes. There are no guarantees around ordering of mutating webhooks (that I could find), so the only way to remedy this properly is to split apart the two into separate webhook configurations:
defaulting: which runs during the mutating admission webhook phasevalidation: which runs during the validating admission webhook phase.The diagram in this post is very helpful in illustrating the flow of webhooks.
Fixes: #847
/hold
I need to stage downstream PRs for this.