Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split apart defaulting and validation webhook #2147

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Split apart defaulting and validation webhook #2147

merged 1 commit into from
Nov 15, 2019

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Nov 6, 2019

Related: knative/pkg#848

/hold
until upstream PR lands.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 6, 2019
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 6, 2019
@mattmoor
Copy link
Member Author

mattmoor commented Nov 6, 2019

/retest

@mattmoor mattmoor force-pushed the split-webhook branch 3 times, most recently from 8583f58 to 22e1ec7 Compare November 6, 2019 01:54
@lionelvillard
Copy link
Member

oops just saw this. Overlaps with #2140 (closed)

@lionelvillard lionelvillard mentioned this pull request Nov 7, 2019
Merged
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 9, 2019
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 14, 2019
@knative knative deleted a comment from mattmoor-sockpuppet Nov 14, 2019
@n3wscott
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2019
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2019
@mattmoor
Copy link
Member Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2019
@n3wscott
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/eventing/v1alpha1/broker_validation.go 95.7% 95.0% -0.7
pkg/apis/eventing/v1alpha1/eventtype_validation.go 95.7% 95.0% -0.7
pkg/apis/eventing/v1alpha1/trigger_validation.go 97.3% 97.2% -0.1
pkg/apis/messaging/v1alpha1/channel_validation.go 93.3% 96.3% 3.0
pkg/apis/messaging/v1alpha1/subscription_validation.go 94.9% 94.4% -0.4

@mattmoor mattmoor mentioned this pull request Nov 15, 2019
Closed
@knative-prow-robot knative-prow-robot merged commit e29ff99 into knative:master Nov 15, 2019
@matzew
Copy link
Member

matzew commented Nov 15, 2019

should we add release notes ?

@vaikas
Copy link
Contributor

vaikas commented Nov 15, 2019

@mattmoor I'm having a hard time figuring out from the other PR if there are any release notes that should be added or if things are self-healing now and there's no need to do anything on releases?

@grantr grantr mentioned this pull request Nov 19, 2019
Closed
@nachocano nachocano mentioned this pull request Dec 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor-sockpuppet mattmoor-sockpuppet mattmoor-sockpuppet left review comments

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@matzew matzew Awaiting requested review from matzew

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mattmoor @lionelvillard @n3wscott @knative-prow-robot @knative-metrics-robot @matzew @vaikas @mattmoor-sockpuppet @googlebot