-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the description about Max revision timeout seconds #5884
Modify the description about Max revision timeout seconds #5884
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @KAZYPinkSaurus! It looks like this is your first PR to knative/docs 🎉 |
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/lgtm |
@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, KAZYPinkSaurus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dprotaso: new pull request created: #5885 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR is related to knative/serving#14969 .
Because TerminationGrace
Period
Seconds is more appropriate than terminationGraceTime
Seconds.The document probably explain about fallowing value.
https://github.com/knative/serving/blob/6dc7097b740f6b0e6ae744abad5e84338a1b8066/config/core/deployments/activator.yaml#L124
I believe this PR makes this document more understandable.
Thank you.
Proposed Changes