Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the description of ConfigMap config-defaults #14969

Conversation

KAZYPinkSaurus
Copy link
Contributor

@KAZYPinkSaurus KAZYPinkSaurus commented Mar 3, 2024

TerminationGracePeriodSeconds is more appropriate than terminationGraceTimeSeconds.
The ConfigMap description probably explain about fallowing value.

terminationGracePeriodSeconds: 600

I believe this PR makes the comment more understandable.

Thank you.

Proposed Changes

  • Modified terminationGraceTimeSeconds in the config map description to terminationGracePeriodSeconds.

Release Note

NONE

Copy link

linux-foundation-easycla bot commented Mar 3, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

knative-prow bot commented Mar 3, 2024

Welcome @KAZYPinkSaurus! It looks like this is your first PR to knative/serving 🎉

Copy link

knative-prow bot commented Mar 3, 2024

Hi @KAZYPinkSaurus. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2024
@dprotaso
Copy link
Member

dprotaso commented Mar 3, 2024

/approve

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2024
@dprotaso
Copy link
Member

dprotaso commented Mar 3, 2024

Thanks for the PR you'll need to run you'll need to run ./hack/update-checksums.sh

@KAZYPinkSaurus
Copy link
Contributor Author

@dprotaso Thank you for your kind review.
I updated checksum.
952e5f8

@dprotaso
Copy link
Member

dprotaso commented Mar 4, 2024

/ok-to-test
/lgtm
/approve

@knative-prow knative-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 4, 2024
@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2024
Copy link

knative-prow bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, KAZYPinkSaurus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.22%. Comparing base (6dc7097) to head (952e5f8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14969      +/-   ##
==========================================
- Coverage   84.23%   84.22%   -0.02%     
==========================================
  Files         213      213              
  Lines       16635    16635              
==========================================
- Hits        14013    14010       -3     
- Misses       2277     2278       +1     
- Partials      345      347       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit f852ac6 into knative:main Mar 5, 2024
45 checks passed
@KAZYPinkSaurus KAZYPinkSaurus deleted the fix-comment-max-revision-timeout-seconds branch March 5, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants