Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Drop Prometheus Source #1586

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Drop Prometheus Source #1586

merged 2 commits into from
Sep 18, 2020

Conversation

lberk
Copy link
Member

@lberk lberk commented Sep 17, 2020

Prometheus source has moved to https://github.com/knative-sandbox/eventing-prometheus

Fixes knative/community#237

Proposed Changes

  • Drop Prometheus Source from eventing-contrib and moving to knative-sandbox

Release Note

The Prometheus source artifacts have moved to https://github.com/knative-sandbox/eventing-prometheus

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 17, 2020
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/test-and-release labels Sep 17, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@lberk
Copy link
Member Author

lberk commented Sep 17, 2020

/hold
need to wait and make sure the nightlies are setup for test-infra releases knative/test-infra#2435

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2020
@aliok aliok mentioned this pull request Sep 18, 2020
Merged
@lberk
Copy link
Member Author

lberk commented Sep 18, 2020

/unhold
continuous is now passing, rebased on latest changes

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2020
@lionelvillard
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020
@lberk
Copy link
Member Author

lberk commented Sep 18, 2020

/test pull-knative-eventing-contrib-build-tests

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020
@lionelvillard
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020
@knative-prow-robot knative-prow-robot merged commit f211629 into knative:master Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aliok aliok Awaiting requested review from aliok

@steuhs steuhs Awaiting requested review from steuhs

@syedriko syedriko Awaiting requested review from syedriko

Assignees

@lionelvillard lionelvillard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Repo: eventing-prometheus
4 participants
@lberk @knative-prow-robot @lionelvillard @googlebot