Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Remove natss #1587

Merged
merged 4 commits into from
Sep 22, 2020
Merged

Remove natss #1587

merged 4 commits into from
Sep 22, 2020

Conversation

matzew
Copy link
Member

@matzew matzew commented Sep 17, 2020

Drop the Natss channel, which has moved to https://github.com/knative-sandbox/eventing-natss

Release Note

The Natss artifacts have moved to https://github.com/knative-sandbox/eventing-natss

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 17, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 17, 2020
@knative-prow-robot knative-prow-robot added area/test-and-release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 17, 2020
@aliok
Copy link
Member

aliok commented Sep 18, 2020

If you fix this pr, can you also add a release note in the PR description for the repo move, similar to the note in #1586 ?

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 18, 2020
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2020
@lberk
Copy link
Member

lberk commented Sep 21, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020
@lberk
Copy link
Member

lberk commented Sep 21, 2020

@matzew looks like a real failure with the test runner:
error: the path "natss/config/broker/natss.yaml" does not exist

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020
Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 7b0f9ca into knative:master Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants