Skip to content

Commit

Permalink
fix(test): creating the knsubscribe clusterrolebinding does not cause…
Browse files Browse the repository at this point in the history
… install script to fail (#8068)

* fix(test) creating the knsusbcribe clusterrolebinding does not cause install script to fail

Signed-off-by: Calum Murray <cmurray@redhat.com>

* cleanup: fixed type in knative_setup

Signed-off-by: Calum Murray <cmurray@redhat.com>

---------

Signed-off-by: Calum Murray <cmurray@redhat.com>
  • Loading branch information
Cali0707 committed Jul 4, 2024
1 parent 8e039dd commit 5f6713a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/e2e-common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function knative_setup() {

install_feature_cm || fail_test "Could not install features configmap"

create_knsubscribe_rolebinding || fail_test "Could not create knsusbcribe rolebinding"
create_knsubscribe_rolebinding || fail_test "Could not create knsubscribe rolebinding"
}

function scale_controlplane() {
Expand All @@ -107,6 +107,7 @@ function scale_controlplane() {
}

function create_knsubscribe_rolebinding() {
kubectl delete clusterrolebinding knsubscribe-test-rb --ignore-not-found=true
kubectl create clusterrolebinding knsubscribe-test-rb --user=$(kubectl auth whoami -ojson | jq .status.userInfo.username -r) --clusterrole=crossnamespace=subscriber
}

Expand Down

0 comments on commit 5f6713a

Please sign in to comment.