-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): creating the knsubscribe clusterrolebinding does not cause install script to fail #8068
fix(test): creating the knsubscribe clusterrolebinding does not cause install script to fail #8068
Conversation
…install script to fail Signed-off-by: Calum Murray <cmurray@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8068 +/- ##
==========================================
+ Coverage 67.91% 67.92% +0.01%
==========================================
Files 366 367 +1
Lines 17164 17323 +159
==========================================
+ Hits 11657 11767 +110
- Misses 4783 4823 +40
- Partials 724 733 +9 ☔ View full report in Codecov by Sentry. |
/test upgrade-tests |
It is not part of this PR, but the error log has the typo here. Line 95 in 033e437
Tested the PR it works perfectly on my local env. |
Signed-off-by: Calum Murray <cmurray@redhat.com>
/cc @Leo6Leo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test reconciler-tests |
Wrong button 😆 |
Currently, re-running the
./hack/install.sh
script fails because the knsubscribe clusterrolebinding was already created.Proposed Changes