Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): creating the knsubscribe clusterrolebinding does not cause install script to fail #8068

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Jul 3, 2024

Currently, re-running the ./hack/install.sh script fails because the knsubscribe clusterrolebinding was already created.

Proposed Changes

  • Delete the clusterrolebinding each time the script is run, ignoring not found errors

…install script to fail

Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 3, 2024

/cc @Leo6Leo @creydr

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.92%. Comparing base (d18595f) to head (8f065ed).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8068      +/-   ##
==========================================
+ Coverage   67.91%   67.92%   +0.01%     
==========================================
  Files         366      367       +1     
  Lines       17164    17323     +159     
==========================================
+ Hits        11657    11767     +110     
- Misses       4783     4823      +40     
- Partials      724      733       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cali0707
Copy link
Member Author

Cali0707 commented Jul 3, 2024

/test upgrade-tests

@Cali0707 Cali0707 changed the title fix(test): creating the knsusbcribe clusterrolebinding does not cause install script to fail fix(test): creating the knsubscribe clusterrolebinding does not cause install script to fail Jul 3, 2024
@Leo6Leo
Copy link
Member

Leo6Leo commented Jul 3, 2024

It is not part of this PR, but the error log has the typo here.

create_knsubscribe_rolebinding || fail_test "Could not create knsusbcribe rolebinding"

Tested the PR it works perfectly on my local env.

Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 4, 2024

/cc @Leo6Leo

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
Copy link

knative-prow bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Cali0707
Copy link
Member Author

Cali0707 commented Jul 4, 2024

/test reconciler-tests

@Cali0707 Cali0707 closed this Jul 4, 2024
@Cali0707 Cali0707 reopened this Jul 4, 2024
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 4, 2024

Wrong button 😆

@knative-prow knative-prow bot merged commit 5f6713a into knative:main Jul 4, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants