Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ko:// image paths #1688

Closed
grantr opened this issue Aug 16, 2019 · 4 comments
Closed

Use ko:// image paths #1688

grantr opened this issue Aug 16, 2019 · 4 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@grantr
Copy link
Contributor

grantr commented Aug 16, 2019

Ko now supports ko:// image paths since ko-build/ko#58, and complains when one of those cannot be resolved. This feature would have prevented the issue with eventing-contrib 0.8.1 (knative/test-infra#1269).

We should add ko:// to all our image paths in yaml and ask developers to upgrade to the latest version of ko.

/cc @imjasonh @matzew
@grantr
Copy link
Contributor Author

grantr commented Aug 16, 2019

/remove-kind feature-request
/kind cleanup

@knative-prow-robot knative-prow-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature-request labels Aug 16, 2019
@imjasonh
Copy link
Member

You'll also need to make sure that ko resolve invocations in tests and release scripts pass the --strict flag.

@n3wscott
Copy link
Contributor

strict is now on by default, so this is done.
/close

@knative-prow-robot
Copy link
Contributor

@n3wscott: Closing this issue.

In response to this:

strict is now on by default, so this is done.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierDipi pushed a commit to pierDipi/eventing that referenced this issue Apr 5, 2022
@matzew
Remove unneeded patch (knative#1688)
0285611 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@grantr @imjasonh @n3wscott @knative-prow-robot