Implement "strict mode" which requires ko:// prefix for import paths
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
changed the title
ko:// prefix for image refsko:// prefix for import paths
If you remove Non- |
When ko is invoked in this mode, import paths must have the `ko://` prefix. If a human marks an import path with `ko://` and ko can't resolve the resulting import path, it fails. In "loose mode", such an import path would be silently ignored and passed on to the resolved YAML, often resulting in invalid image names (e.g., `image: github.com/foo/bar`) In loose mode, `ko://` prefixes are always ignored for backward-compatibility.
Strictness has nothing to do with building, and is independent of how images are built (fixed builder, some future exotic builder type, etc.)
jonjohnsonjr
approved these changes
Aug 15, 2019
pkg/commands/options/strict.go
Outdated
| } | ||
|
|
||
| func AddStrictArg(cmd *cobra.Command, so *StrictOptions) { | ||
| cmd.Flags().BoolVarP(&so.Strict, "strict", "S", so.Strict, |
There was a problem hiding this comment.
I'm mildly -1 on including -S -- we will eventually run out of flags if we keep this up :P
There was a problem hiding this comment.
Yeah, I kind of agree. I'll remove -S until someone complains it's too much to type.
This was referenced Aug 16, 2019
This was referenced Oct 22, 2019
evandbrown
pushed a commit
to google/kf
that referenced
this pull request
Jan 8, 2020
To allow for ko and Go modules to work well, we need to use the `ko://` prefix for our paths. This allows us to use `ko apply --strict ...`. More information can be found in the ko [PR](ko-build/ko#58). Change-Id: I5f33c56465476c81ff73085ccc5776064f8187cf
poy
added a commit
to poy/pipeline
that referenced
this pull request
Mar 11, 2020
This allows `ko` to improve the experience with Go modules. See ko-build/ko#58 for more information.
3 tasks
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Apr 1, 2020
This allows `ko` to improve the experience with Go modules. See ko-build/ko#58 for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrating a strawman implementation and UX for "strict mode", as described in #9
In strict mode, image references are only considered if they begin with the string
ko://. In loose mode,ko://refs are considered as image references and built and replaced during YAML resolution.If we decide to pursue this model, we could start by making strictness opt-in, cut a versioned release of
ko, then make--strict=trueby default (opt-out), then eventually maybe even remove the option.Sending this out to get feedback on the overall idea; it sounds like Go modules is going to be pretty painful without this as an option at least.