-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delivery Format: add the format
field to the Delivery type
#8073
Comments
/good-first-issue |
@Cali0707: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Whoops sorry @EraKin575 I think I messed up the project automation there so this got closed accidentally, I've reopened it now - feel free to ask for help if you need it as you work on it! |
thanks! @Cali0707 . I got really confused there |
@Cali0707 this field just needs to be added in the struct and validate in Validate function, right? Nothing else to do? |
Problem
To support more destinations of cloudevents (which may require a specific event format) we need to add the
format
field to the DeliverySpec type which is embedded into many of our types.Persona:
Which persona is this feature for?
Exit Criteria
The
format
field is present in the DeliverySpec type, and is validated to be one of:nil
structured
binary
ingress
Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1
Additional context (optional)
Add any other context about the feature request here.
eventing/pkg/apis/duck/v1/delivery_types.go
Lines 31 to 84 in 8e039dd
The text was updated successfully, but these errors were encountered: