Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delivery format: Support the format field on the subscription delivery spec for IMC #8078

Open
Cali0707 opened this issue Jul 4, 2024 · 5 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request

Comments

@Cali0707
Copy link
Member

Cali0707 commented Jul 4, 2024

Problem
To allow for specifying the cloudevent format when delivering events from a subscription to an imc, we should support the format field on the delivery spec of the subscription. Specifically we will need to:

  1. Add the field to the CRD
  2. Depending on the value of the field, correctly configure the kncloudevents dispatcher in the imc dispatcher component to send the cloudevent with the correct binding

Persona:
Which persona is this feature for?

Exit Criteria
An e2e test indicating that subscriptions deliver events with the correct format (structured, binary, input)

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1-2

Additional context (optional)
Add any other context about the feature request here.

@Cali0707
Copy link
Member Author

Cali0707 commented Jul 4, 2024

/help
Note that this needs #8073 #8074 and #8076 to be resolved before it can be worked on

Copy link

knative-prow bot commented Jul 4, 2024

@Cali0707:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
Note that this needs #8073 #8074 and #8076 to be resolved before it can be worked on

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 4, 2024
@EraKin575
Copy link
Contributor

/assign

@Cali0707
Copy link
Member Author

Cali0707 commented Jul 4, 2024

Hey @EraKin575 just a heads up, this issue isn't ready to be worked on (as I specified in #8078 (comment) there are a few other issues which will need to be resolved first)

@EraKin575
Copy link
Contributor

EraKin575 commented Jul 5, 2024

Sure. Thanks for informing.Please comment when it is ready to be worked on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request
Projects
Development

No branches or pull requests

2 participants