Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delivery Format: support specifying the event format in the kncloudevents dispatcher #8074

Closed
Cali0707 opened this issue Jul 4, 2024 · 3 comments · Fixed by #8096
Closed

Delivery Format: support specifying the event format in the kncloudevents dispatcher #8074

Cali0707 opened this issue Jul 4, 2024 · 3 comments · Fixed by #8096
Assignees
@EraKin575
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@Cali0707
Copy link
Member

Cali0707 commented Jul 4, 2024

Problem
Throughout eventing, we use the kncloudevents dispatcher to dispatch cloudevents. We should add a SendOption which allows us to specify the format used when sending the events, along the lines of:

dispatcher.SendEvent(ctx, event, destination, WithEventFormat(format.Structured))

When no event format is specified, we should preserve the existing behavior of the package.

Persona:
Which persona is this feature for?

Exit Criteria
A unit test which sends an even with the structured format set and verifies that it gets a structured event, and a unit test which does the same for the binary format

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1-2

Additional context (optional)
Add any other context about the feature request here.
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 4, 2024

/good-first-issue

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 4, 2024

@Cali0707:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 4, 2024
@Cali0707 Cali0707 added the triage/accepted Issues which should be fixed (post-triage) label Jul 4, 2024
This was referenced Jul 4, 2024
Open
Open
@EraKin575
Copy link
Contributor

/assign

@EraKin575 EraKin575 mentioned this issue Jul 11, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EraKin575 EraKin575

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
Eventing Delivery Format
Status: Ready
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added event format to dispatcher EraKin575/eventing
2 participants
@Cali0707 @EraKin575