Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Eventing TLS: add tests for dynamically added CA trust bundles #7726

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

[WIP] Eventing TLS: add tests for dynamically added CA trust bundles #7726

wants to merge 18 commits into from

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Feb 27, 2024 •
edited
Loading

This adds new tests for testing when CA trust bundles are dynamically added to the clients trust stores

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Feb 27, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 31.25000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 67.64%. Comparing base (a6ac811) to head (e1c9599).

Files Patch % Lines
pkg/eventingtls/trust_bundle.go 0.00% 15 Missing ⚠️
pkg/apis/sources/v1/sinkbinding_lifecycle.go 52.00% 9 Missing and 3 partials ⚠️
pkg/reconciler/sinkbinding/controller.go 0.00% 4 Missing ⚠️
pkg/reconciler/sinkbinding/sinkbinding.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7726      +/-   ##
==========================================
- Coverage   67.70%   67.64%   -0.06%     
==========================================
  Files         364      364              
  Lines       17042    17074      +32     
==========================================
+ Hits        11538    11550      +12     
- Misses       4783     4800      +17     
- Partials      721      724       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi pierDipi mentioned this pull request Feb 27, 2024
Merged
@pierDipi
Add CA rotation tests
023a7ce 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@maschmid
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2024
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2024
matzew
matzew approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@matzew
Copy link
Member

matzew commented Apr 25, 2024

I rebased this PR 🙏

@matzew
Copy link
Member

matzew commented Apr 25, 2024

/cherry-pick release-1.14

@knative-prow-robot
Copy link
Contributor

@matzew: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matzew
Copy link
Member

matzew commented Apr 25, 2024

/cherry-pick release-1.13

@knative-prow-robot
Copy link
Contributor

@matzew: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matzew
Copy link
Member

matzew commented Apr 25, 2024

/test reconciler-tests

2 similar comments
@matzew
Copy link
Member

matzew commented Apr 25, 2024

/test reconciler-tests

@matzew
Copy link
Member

matzew commented Apr 25, 2024

/test reconciler-tests

@pierDipi pierDipi force-pushed the ca-rotation-tests branch 2 times, most recently from 9b9892c to e4eba93 Compare May 22, 2024 06:22
@pierDipi
Add propagation improvements for webhook (running before reconciler)
0c5a8a1 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Add ETv1b3 conversion
f3edb9d 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 22, 2024
@pierDipi
Inject Kubeclient
c592d8e 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Exclude core deployments from webhook injection
8e40ea4 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Fix unit tests
69ae4bd 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Merge branch 'main' into ca-rotation-tests
380fa2f
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2024
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 5, 2024
@pierDipi
Copy link
Member Author

/test reconciler-tests

@pierDipi
Copy link
Member Author

/test reconciler-tests

@pierDipi
Use managed T for ApiServerSource TLS tests
a47ca0c 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Reduce number of retries
d1f7ece 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Fix test configmap nodeselector config
ec5b4b1 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Member Author 

/test unit-tests

1 similar comment
@pierDipi
Copy link
Member Author

/test unit-tests

@pierDipi pierDipi changed the title Eventing TLS: add tests for dynamically added CA trust bundles [WIP] Eventing TLS: add tests for dynamically added CA trust bundles Jun 12, 2024
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 27, 2024

@pierDipi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests_eventing_main e1c9599 link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@mgencur mgencur Awaiting requested review from mgencur

@maschmid maschmid Awaiting requested review from maschmid

Assignees

@matzew matzew

@maschmid maschmid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pierDipi @maschmid @matzew @knative-prow-robot