Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect trust bundles changes #3723

Merged

Conversation

pierDipi
Copy link
Member

As per title

This will be E2E tested with tests in knative/eventing#7726

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/control-plane labels Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 43.47826% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 52.66%. Comparing base (955a886) to head (72af050).
Report is 3 commits behind head on main.

Files Patch % Lines
control-plane/pkg/core/config/utils.go 0.00% 6 Missing ⚠️
control-plane/pkg/reconciler/broker/broker.go 50.00% 3 Missing and 2 partials ⚠️
control-plane/pkg/reconciler/channel/channel.go 50.00% 3 Missing and 2 partials ⚠️
control-plane/pkg/reconciler/consumer/consumer.go 50.00% 3 Missing and 2 partials ⚠️
control-plane/pkg/reconciler/sink/kafka_sink.go 50.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3723      +/-   ##
============================================
- Coverage     52.67%   52.66%   -0.02%     
- Complexity      859      874      +15     
============================================
  Files           339      340       +1     
  Lines         21087    21213     +126     
  Branches        276      284       +8     
============================================
+ Hits          11108    11171      +63     
- Misses         9075     9131      +56     
- Partials        904      911       +7     
Flag Coverage Δ
java-unittests 74.05% <ø> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member Author

/test reconciler-tests-keda

@pierDipi
Copy link
Member Author

/cc @creydr @Cali0707

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
Copy link

knative-prow bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

/retest

@creydr
Copy link
Contributor

creydr commented Feb 28, 2024

/test reconciler-tests-namespaced-broker

@knative-prow knative-prow bot merged commit 22b65aa into knative-extensions:main Feb 28, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants