Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.11] Detect trust bundles changes #999

Merged
merged 1 commit into from
Feb 28, 2024
Merged

[release-v1.11] Detect trust bundles changes #999

merged 1 commit into from
Feb 28, 2024

Conversation

pierDipi
Copy link
Member

@pierDipi
Detect trust bundles changes
d756b87 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@openshift-ci openshift-ci bot requested review from creydr and matzew February 27, 2024 15:14
matzew
matzew approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Feb 27, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ed42c15 and 2 for PR HEAD d756b87 in total

@matzew
Copy link
Member

matzew commented Feb 28, 2024

/retest

1 similar comment
@matzew
Copy link
Member

matzew commented Feb 28, 2024

/retest

@pierDipi
Copy link
Member Author

/override ci/prow/414-test-reconciler-keda-aws-414

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 28, 2024

@pierDipi: Overrode contexts on behalf of pierDipi: ci/prow/414-test-reconciler-keda-aws-414

In response to this:

/override ci/prow/414-test-reconciler-keda-aws-414

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matzew matzew merged commit dde7d36 into openshift-knative:release-v1.11 Feb 28, 2024
13 of 14 checks passed
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 28, 2024

@pierDipi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/412-test-e2e-aws-412 d756b87 link unknown /test 412-test-e2e-aws-412
ci/prow/414-test-reconciler-encryption-auth-aws-414 d756b87 link unknown /test 414-test-reconciler-encryption-auth-aws-414
ci/prow/414-test-conformance-aws-414 d756b87 link unknown /test 414-test-conformance-aws-414
ci/prow/414-test-e2e-aws-414 d756b87 link unknown /test 414-test-e2e-aws-414
ci/prow/414-test-reconciler-aws-414 d756b87 link unknown /test 414-test-reconciler-aws-414
ci/prow/414-test-reconciler-keda-aws-414 d756b87 link unknown /test 414-test-reconciler-keda-aws-414
ci/prow/412-test-reconciler-aws-412 d756b87 link unknown /test 412-test-reconciler-aws-412
ci/prow/412-test-reconciler-keda-aws-412 d756b87 link unknown /test 412-test-reconciler-keda-aws-412

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@matzew matzew mentioned this pull request Apr 25, 2024
Merged
openshift-merge-bot bot pushed a commit that referenced this pull request Apr 25, 2024
@matzew @pierDipi
Detect trust bundles changes (#999) (#1065)
41d50c1 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@creydr creydr Awaiting requested review from creydr

@maschmid maschmid Awaiting requested review from maschmid

Assignees

@matzew matzew

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierDipi @openshift-ci-robot @matzew