Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Eventing TLS: add tests for dynamically added CA trust bundles #7726

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Merge branch 'main' into ca-rotation-tests

e1c9599
Select commit
Loading
Failed to load commit list.
Open

[WIP] Eventing TLS: add tests for dynamically added CA trust bundles #7726

Merge branch 'main' into ca-rotation-tests
e1c9599
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 27, 2024 in 0s

67.64% (target 80.00%)

View this Pull Request on Codecov

67.64% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 31.25000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 67.64%. Comparing base (a6ac811) to head (e1c9599).

Files Patch % Lines
pkg/eventingtls/trust_bundle.go 0.00% 15 Missing ⚠️
pkg/apis/sources/v1/sinkbinding_lifecycle.go 52.00% 9 Missing and 3 partials ⚠️
pkg/reconciler/sinkbinding/controller.go 0.00% 4 Missing ⚠️
pkg/reconciler/sinkbinding/sinkbinding.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7726      +/-   ##
==========================================
- Coverage   67.70%   67.64%   -0.06%     
==========================================
  Files         364      364              
  Lines       17042    17074      +32     
==========================================
+ Hits        11538    11550      +12     
- Misses       4783     4800      +17     
- Partials      721      724       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov