Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.14] Containersource use OIDC identity of corresponding SinkBinding #7892

Conversation

creydr
Copy link
Member

@creydr creydr commented May 3, 2024

Backport of #7890 (without e2e tests, as they require a reconciler-test update)

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 3, 2024
@creydr
Copy link
Member Author

creydr commented May 3, 2024

/cherry-pick release-1.13

@knative-prow-robot
Copy link
Contributor

@creydr: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-1.14@c1c7c9b). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.14    #7892   +/-   ##
===============================================
  Coverage                ?   69.48%           
===============================================
  Files                   ?      340           
  Lines                   ?    15710           
  Branches                ?        0           
===============================================
  Hits                    ?    10916           
  Misses                  ?     4124           
  Partials                ?      670           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
@creydr
Copy link
Member Author

creydr commented May 3, 2024

Sry, @pierDipi but I needed to fix some style/gofmt issues. Could you recheck?

@creydr
Copy link
Member Author

creydr commented May 3, 2024

/retest-required

@creydr
Copy link
Member Author

creydr commented May 6, 2024

/test reconciler-tests

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
Copy link

knative-prow bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Cali0707,creydr,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 3ac9df6 into knative:release-1.14 May 6, 2024
23 of 24 checks passed
@knative-prow-robot
Copy link
Contributor

@creydr: #7892 failed to apply on top of branch "release-1.13":

Applying: Revert "feat: support auto generation of ContainerSource identity service account and expose in AuthStatus (#7461)"
Using index info to reconstruct a base tree...
M	pkg/reconciler/containersource/controller.go
M	pkg/reconciler/containersource/controller_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/reconciler/containersource/controller_test.go
Auto-merging pkg/reconciler/containersource/controller.go
CONFLICT (content): Merge conflict in pkg/reconciler/containersource/controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Revert "feat: support auto generation of ContainerSource identity service account and expose in AuthStatus (#7461)"
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants