-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.14] Containersource use OIDC identity of corresponding SinkBinding #7892
[release-1.14] Containersource use OIDC identity of corresponding SinkBinding #7892
Conversation
…vice account and expose in AuthStatus (knative#7461)" This reverts commit 116abe2.
/cherry-pick release-1.13 |
@creydr: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.14 #7892 +/- ##
===============================================
Coverage ? 69.48%
===============================================
Files ? 340
Lines ? 15710
Branches ? 0
===============================================
Hits ? 10916
Misses ? 4124
Partials ? 670 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Sry, @pierDipi but I needed to fix some style/gofmt issues. Could you recheck? |
/retest-required |
/test reconciler-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@creydr: #7892 failed to apply on top of branch "release-1.13":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Backport of #7890 (without e2e tests, as they require a reconciler-test update)