Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.13] Containersource use OIDC identity of corresponding SinkBinding #7898

Conversation

creydr
Copy link
Member

@creydr creydr commented May 7, 2024

Backport of #7890 (without e2e tests, as they require a reconciler-test update).

Manual backport, as of #7892 (comment)

@creydr creydr requested review from pierDipi and Cali0707 May 7, 2024 06:13
@knative-prow knative-prow bot requested a review from aslom May 7, 2024 06:13
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 7, 2024
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
Copy link

knative-prow bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.22%. Comparing base (d045c98) to head (4e0e3c9).
Report is 2 commits behind head on release-1.13.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.13    #7898      +/-   ##
================================================
+ Coverage         69.38%   70.22%   +0.84%     
================================================
  Files               336      336              
  Lines             19162    15303    -3859     
================================================
- Hits              13296    10747    -2549     
+ Misses             5209     3898    -1311     
- Partials            657      658       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit 0673f36 into knative:release-1.13 May 7, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants