Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sequence updates subscription where possible, instead of recreating it #7948

Merged
merged 3 commits into from
Jun 3, 2024

cleanup: use method from api folder to check immutable fields

924f7a6
Select commit
Loading
Failed to load commit list.
Merged

fix: sequence updates subscription where possible, instead of recreating it #7948

cleanup: use method from api folder to check immutable fields
924f7a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 3, 2024 in 0s

69.55% (target 80.00%)

View this Pull Request on Codecov

69.55% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 69.55%. Comparing base (abdbf14) to head (924f7a6).
Report is 9 commits behind head on main.

Files Patch % Lines
pkg/reconciler/sequence/sequence.go 42.85% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7948      +/-   ##
==========================================
+ Coverage   69.51%   69.55%   +0.03%     
==========================================
  Files         344      344              
  Lines       15994    16055      +61     
==========================================
+ Hits        11119    11167      +48     
- Misses       4189     4199      +10     
- Partials      686      689       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov