Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.13] fix: sequence updates subscription where possible, instead of recreating it #7959

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #7948

sequences now update subscriptions instead of recreating them, where possible

…mmutable fields

Signed-off-by: Calum Murray <cmurray@redhat.com>
…iptions

Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Copy link

knative-prow bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-prow-robot
Once this PR has been reviewed and has the lgtm label, please assign pierdipi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 3, 2024
@Cali0707
Copy link
Member

Cali0707 commented Jun 3, 2024

/assign @pierDipi

From our slack conversation, I'm not 100% sure whether or not we should backport this so I'm leaving it to you

@Cali0707
Copy link
Member

Since 1.13 is not supported anymore, I am closing this PR

@Cali0707 Cali0707 closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants