Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.13] fix: sequence updates subscription where possible, instead of recreating it #7959

Closed
wants to merge 3 commits into from
Closed

[release-1.13] fix: sequence updates subscription where possible, instead of recreating it #7959

wants to merge 3 commits into from

Commits on Jun 3, 2024

  1. feat: sequences only recreate subscriptions when the changes are to i… 

    …mmutable fields

Signed-off-by: Calum Murray <cmurray@redhat.com>
    @Cali0707 @knative-prow-robot
    Cali0707 authored and knative-prow-robot committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    2d9349a View commit details
    Browse the repository at this point in the history

  2. fix(tests): sequence unit tests correctly check for updates to subscr… 

    …iptions

Signed-off-by: Calum Murray <cmurray@redhat.com>
    @Cali0707 @knative-prow-robot
    Cali0707 authored and knative-prow-robot committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    e4f7e14 View commit details
    Browse the repository at this point in the history

  3. cleanup: use method from api folder to check immutable fields 

    Signed-off-by: Calum Murray <cmurray@redhat.com>
    @Cali0707 @knative-prow-robot
    Cali0707 authored and knative-prow-robot committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    5f2ed77 View commit details
    Browse the repository at this point in the history