[release-1.13]: Watch only our own OIDC-related secrets (#8070) #8072
Conversation
Filter OIDC secrets Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
knative-prow
bot
added
approved
Signed-off-by: Calum Murray <cmurray@redhat.com>
knative-prow
bot
added
size/L
Signed-off-by: Calum Murray <cmurray@redhat.com>
…native#7527) Signed-off-by: Calum Murray <cmurray@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test reconciler-tests |
1 similar comment
|
/test reconciler-tests |
|
/retest |
|
/test reconciler-tests |
Looks like a real failure, will debug... |
Signed-off-by: Calum Murray <cmurray@redhat.com>
Cali0707
force-pushed
the
backport-filter-oidc-informer-release-1.13
branch
from
015bce0
to
86da06c
Compare
|
/test reconciler-tests |
| @@ -80,8 +80,8 @@ func NewController( | |||
| dc := dynamicclient.Get(ctx) | |||
| psInformerFactory := podspecable.Get(ctx) | |||
| namespaceInformer := namespace.Get(ctx) | |||
| serviceaccountInformer := serviceaccountinformer.Get(ctx) | |||
| secretInformer := secretinformer.Get(ctx) | |||
| oidcServiceaccountInformer := serviceaccountinformer.Get(ctx) | |||
There was a problem hiding this comment.
did we just rename it for a better name?
There was a problem hiding this comment.
Yeah the name was changed later, so when I did the cherry-pick it seems to have included that as well
There was a problem hiding this comment.
ok, I see is now same name as on main
|
/test reconciler-tests |
|
/lgtm |
This is a backport of #8070 to ensure that we use a filtered informer for our own OIDC-related secrets to reduce memory usage.