-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watch only our own OIDC-related secrets #8070
Conversation
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.33 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.14 |
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.13 |
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8070 +/- ##
==========================================
- Coverage 67.92% 67.89% -0.04%
==========================================
Files 367 367
Lines 17323 17332 +9
==========================================
Hits 11767 11767
- Misses 4823 4832 +9
Partials 733 733 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test upgrade-tests |
@pierDipi: new pull request created: #8071 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@pierDipi: #8070 failed to apply on top of branch "release-1.13":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Filter OIDC secrets Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Filter OIDC secrets Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Filter OIDC secrets Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Filter OIDC secrets Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Filter OIDC secrets Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
* Watch only our own OIDC-related secrets (#8070) Filter OIDC secrets Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * ./hack/update-deps.sh Signed-off-by: Calum Murray <cmurray@redhat.com> * fix: serviceaccountInformer -> oidcServiceaccountInformer Signed-off-by: Calum Murray <cmurray@redhat.com> * fix: add oidc label selector to main contexts (partial cherry pick of #7527) Signed-off-by: Calum Murray <cmurray@redhat.com> * fix: don't use filtered sa informer when sa is not labelled Signed-off-by: Calum Murray <cmurray@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Signed-off-by: Calum Murray <cmurray@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
This reduces memory consumption on large clusters by watching only our own OIDC-related secrets