Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.14]: Watch only our own OIDC-related secrets (#8070) #696

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Jul 4, 2024

This is a backport of knative#8070 to ensure that we use a filtered informer for our own OIDC-related secrets to reduce memory usage.

Filter OIDC secrets

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@Cali0707
Copy link
Member Author

Cali0707 commented Jul 4, 2024

/cc @matzew @pierDipi

@openshift-ci openshift-ci bot requested review from matzew, pierDipi and creydr July 4, 2024 17:48
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 5, 2024
@matzew
Copy link
Member

matzew commented Jul 5, 2024

/test 412-test-encryption-auth-e2e-aws-412

@openshift-merge-bot openshift-merge-bot bot merged commit 290c838 into openshift-knative:release-v1.14 Jul 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants