Removing workaround to disable selinux label - updated #645
Conversation
|
@Shashankft9: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow-robot
added
the
size/XXL
Codecov Report
@@ Coverage Diff @@
## main #645 +/- ##
=======================================
Coverage 36.26% 36.26%
=======================================
Files 38 38
Lines 3847 3847
=======================================
Hits 1395 1395
Misses 2268 2268
Partials 184 184 Continue to review full report at Codecov.
|
buildpacks/builder.go
Outdated
| // Client with a logger which is enabled if in Verbose mode. | ||
| packClient, err := pack.NewClient(pack.WithLogger(logging.New(logWriter)), pack.WithDockerClient(dockerClientWrapper)) | ||
| packClient, err := pack.NewClient(pack.WithLogger(logging.NewSimpleLogger(logWriter))) |
There was a problem hiding this comment.
@Shashankft9 custom docker client cli still should be set in order to support SSH.
|
Apart for the single comment this looks good. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek, Shashankft9 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/hold until CI pass |
knative-prow-robot
added
the
do-not-merge/hold
|
/lgtm |
|
/unhold |
knative-prow-robot
removed
the
do-not-merge/hold
* deps: update tekton to latest versions (knative#1753) Fixes: knative#1716 Signed-off-by: Lance Ball <lball@redhat.com> Signed-off-by: Matej Vasek <mvasek@redhat.com> * fixup: update CI Go version Signed-off-by: Matej Vasek <mvasek@redhat.com> * fixup: update golangci-lit version Signed-off-by: Matej Vasek <mvasek@redhat.com> * fixup: update github.com/tektoncd/cli Signed-off-by: Matej Vasek <mvasek@redhat.com> * fixup: delete replacement of tekton lib version Signed-off-by: Matej Vasek <mvasek@redhat.com> --------- Signed-off-by: Lance Ball <lball@redhat.com> Signed-off-by: Matej Vasek <mvasek@redhat.com>
Changes
TrustBuilderin pack buildOptions from bool to func to accomodate this change: Make pack golang API trust the suggested builders by default buildpacks/pack#1274 and more changes related to pack restructure: Restructure pack client to pkg package buildpacks/pack#1315/kind cleanup
Fixes #390 (comment)
I came across this code in builder.go few days ago, and saw in the comments that it was a workaround till the issue mentioned above is fixed, so did a fix here: buildpacks/pack#1307 and the next logical thing seemed to cleanup the code, so I tried that here - please let me know if this is not required.