🐛 Collect LICENSE files from all dependencies, even without vendor dir #316
Conversation
knative-prow
bot
added
approved
There was a problem hiding this comment.
was this committed by accident?
There was a problem hiding this comment.
No. Those are sums on the workspace level. It's the same concept as sums on module level.
However, I'm not entirely sure how they are used...
There was a problem hiding this comment.
Here's some info: https://stackoverflow.com/a/71613130
It's a bit of a useless thing, at least my understanding, but still it's a part of go tooling...
There was a problem hiding this comment.
What's more confusing for me, is that this file was updated after I executed our update deps script, which runs go mod tidy in every module. This should sync proper deps in modules and the workspace file should be empty.
Maybe the update deps script should delete the go.work.sum file before the loop?!?
There was a problem hiding this comment.
I'm sorta mixed on whether we should check in go.work files - there seems to be a discussion here
There was a problem hiding this comment.
hack repo since it has with multiple modules seems like a candidate 🤷
|
/lgtm |
|
@upodroid: Overrode contexts on behalf of upodroid: style / suggester / shell In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, dprotaso, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
/kind bug
Fixes #315
Release Note