🐛 The go.work.sum don't influence the dependencies resolution

[cardil]

If it's not needed. If the file isn't empty after the update, it should be committed.

Some info: https://stackoverflow.com/a/71613130

Changes

• 🐛 The go.work.sum don't influence the dependencies resolution

/kind bug

Follow up #316

[cardil]

/cc @dprotaso
/cc @upodroid
/cc @kvmware

[cardil]

What's strange, when I open the project in Goland IDE, or invoke a "Sync Go Module" operation in that IDE, the go.work.sum is being recreated with the contents of #316.

The Goland IDE must call some go command, but I don't know which one.

[dprotaso]

There really shouldn't be any dependencies in the hack repo - the original intention was for it to just propagate shell scripts to other repos

Now the deps used here will have an influence of the version selection (might not be a big issue) - but I would encourage moving tools to toolbox and test fixtures can be generated programmatically or put under testdata (eg. test vendor project)

[dprotaso]

Also note this dep is now in the stdlib

hack/go.mod

Line 6 in c4a34c3

github.com/pkg/errors v0.9.1

https://pkg.go.dev/errors

[cardil]

@dprotaso There really shouldn't be any dependencies in the hack repo - the original intention was for it to just propagate shell scripts to other repos

Now the deps used here will have an influence of the version selection (might not be a big issue) - but I would encourage moving tools to toolbox and test fixtures can be generated programmatically or put under testdata (eg. test vendor project)

Good point. I think this is an oversight on my side, while doing the #222. Before that PR there ware go deps, but only in isolated go sub modules.

We could move the cmd/script to the toolbox, or just create an additional go.mod in cmd.

Let's capture this in a separate issue.

[cardil]

@dprotaso the issue #318

[dprotaso]

/lgtm
/approve

[cardil]

/override style / suggester / shell

[knative-prow]

@cardil: cardil unauthorized: /override is restricted to Repo administrators.

In response to this:

/override style / suggester / shell

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[upodroid]

/override "style / suggester / shell"

[knative-prow]

@upodroid: Overrode contexts on behalf of upodroid: style / suggester / shell

In response to this:

/override "style / suggester / shell"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cardil,dprotaso,upodroid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment