-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to k8s v0.24.4 client packages #2586
Conversation
@jonathan-innis: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Welcome @jonathan-innis! It looks like this is your first PR to knative/pkg 🎉 |
Hi @jonathan-innis. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c703910
to
d7ce1d2
Compare
/assign @matzew |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## main #2586 +/- ##
=======================================
Coverage 81.25% 81.25%
=======================================
Files 162 162
Lines 9801 9801
=======================================
Hits 7964 7964
Misses 1597 1597
Partials 240 240 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@dprotaso I'm assuming that these tests are failing downstream due to them using |
/lgtm I'll address deprecations in another PR |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR fixes the deprecations #2589 |
Changes
Karpenter uses knative injection packages in our project and are currently blocked on upgrading packages due to knative supported Kubernetes version
v1.24.x
I found the development documentation lacking for how to build and test changes as well as how to use the
codegen
to generate the relevant code so please correct any of the changes that do not make sense./kind cleanup
Fixes #
Release Note
Docs