Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to k8s v0.24.4 client packages #2586

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Sep 3, 2022

Changes

Karpenter uses knative injection packages in our project and are currently blocked on upgrading packages due to knative supported Kubernetes version

  • This PR upgrades Kubernetes packages to v1.24.x

I found the development documentation lacking for how to build and test changes as well as how to use the codegen to generate the relevant code so please correct any of the changes that do not make sense.

/kind cleanup

Fixes #

Release Note

None

Docs


@knative-prow
Copy link

knative-prow bot commented Sep 3, 2022

@jonathan-innis: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 3, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jonathan-innis / name: Jonathan Innis (c703910)

@knative-prow
Copy link

knative-prow bot commented Sep 3, 2022

Welcome @jonathan-innis! It looks like this is your first PR to knative/pkg 🎉

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 3, 2022
@knative-prow
Copy link

knative-prow bot commented Sep 3, 2022

Hi @jonathan-innis. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jonathan-innis
Copy link
Contributor Author

/assign @matzew

@dprotaso
Copy link
Member

dprotaso commented Sep 7, 2022

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #2586 (d7ce1d2) into main (93b66e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2586   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files         162      162           
  Lines        9801     9801           
=======================================
  Hits         7964     7964           
  Misses       1597     1597           
  Partials      240      240           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jonathan-innis
Copy link
Contributor Author

@dprotaso I'm assuming that these tests are failing downstream due to them using v0.23.9 of k8s.io packages. What is the order of operations for upgrading to the latest package. Since there is a breaking change, I'm assuming this one should go in first and the downstream changes can take dependency on knative/pkg and v0.24.4 of k8s.io packages

@dprotaso
Copy link
Member

dprotaso commented Sep 9, 2022

/lgtm
/approve

I'll address deprecations in another PR

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2022
@knative-prow
Copy link

knative-prow bot commented Sep 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2022
@knative-prow knative-prow bot merged commit 20aabd5 into knative:main Sep 9, 2022
@jonathan-innis jonathan-innis deleted the bump-v0.24.4 branch September 9, 2022 15:35
@dprotaso
Copy link
Member

This PR fixes the deprecations #2589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants