Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Bump knative.pkg deps to v0.26.1 #2673

Closed
wants to merge 1 commit into from

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Feb 5, 2023

Changes

  • Bump knative.pkg deps to 1.26
    Ran ./hack/update-k8s-deps.sh v0.26.1 which code-gened everything

/kind cleanup

Fixes #

Release Note

None

Docs


@knative-prow
Copy link

knative-prow bot commented Feb 5, 2023

@jonathan-innis: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • Bump knative.pkg deps to 1.26

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow
Copy link

knative-prow bot commented Feb 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jonathan-innis
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval by writing /assign @dsimansk in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
Copy link

knative-prow bot commented Feb 5, 2023

Hi @jonathan-innis. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 5, 2023
@jonathan-innis jonathan-innis changed the title 🧹 Bump knative.pkg deps to 1.26 🧹 Bump knative.pkg deps to v0.26.1 Feb 5, 2023
@jonathan-innis jonathan-innis force-pushed the bump-k8s-1.26 branch 4 times, most recently from 1088fa2 to 3ed1d0c Compare February 6, 2023 00:00
@knative-prow knative-prow bot added area/test-and-release do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Feb 6, 2023
@jonathan-innis jonathan-innis force-pushed the bump-k8s-1.26 branch 3 times, most recently from 429d36d to a1e5b10 Compare February 6, 2023 00:17
@knative-prow knative-prow bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 6, 2023
@jonathan-innis jonathan-innis force-pushed the bump-k8s-1.26 branch 6 times, most recently from c64426d to 663c1c8 Compare February 6, 2023 07:01
@dprotaso
Copy link
Member

dprotaso commented Feb 6, 2023

/hold

We're still targeting K8s 1.24 for our next release so we'll want to keep our client libs at 0.25.x - because of the K8s skew policy - ie. https://kubernetes.io/releases/version-skew-policy/#kubectl

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2023
@jonathan-innis
Copy link
Contributor Author

@dprotaso Got it, I guess we will have to wait until then...I wonder why this one was allowed to go last time #2586. I guess the release had already started supporting 1.24 for that one

@dprotaso
Copy link
Member

dprotaso commented Feb 6, 2023

I wonder why this one was allowed to go last time #2586

Yeah - Knative 1.8 targeted K8s 1.23 which is supported by client-go 1.24 libs. We pull in client-go libs N+1 when we target K8s version N.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2023
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member

I'm gonna close this out as we'll revisit this at a later date

@dprotaso dprotaso closed this Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-and-release do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants