Add a way to get commitId for master branch #574
Conversation
knative-prow-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: srinivashegde86 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @yanweiguo |
|
/lgtm |
| ) | ||
|
|
||
| var ( | ||
| commitIDRE = regexp.MustCompile(`^[a-f0-9]{40}$`) | ||
| ) | ||
|
|
||
| // Get tries to fetch the first 7 digitals of GitHub commit ID from HEAD file in | ||
| // get tries to fetch the first 7 digitals of GitHub commit ID from given file in |
There was a problem hiding this comment.
| // get tries to fetch the first 7 digitals of GitHub commit ID from given file in | |
| // get tries to fetch the first 7 hex digits of GitHub commit ID from given file in |
Not strongly set on this, but it reads better for me. Same below.
knative-prow-robot
added
the
do-not-merge/hold
|
With ko-build/ko#73 we can |
|
#576 adds this change to read from the links in .git/HEAD. CLosing this PR as we can use that. |
Currently, we only look at
.git/HEADto get commitId. But, this only provides us with the commitId when the head is in detached state. If we are working on some branch, this will give us a ref to the branch head, which we should then read to get the commitId for that branch.This PR adds a way to get the commitId from the master branch.