Add support for recursively resolving directory symlinks. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for properly resolving directory symlinks within kodata. I verified that with this I can symlink `.git/refs` into `kodata/` and (with changes) resolve the `.git/HEAD` symlink to read the appropriate `ref: refs/heads/...` files with the commit SHA.
mattmoor
added a commit
to mattmoor/pkg
that referenced
this pull request
Aug 15, 2019
With ko-build/ko#73 we can link the Git ref information into images with: ``` ln -r -s .git/refs ./cmd/foo/kodata ``` If the changeset package gets a `ref: <ref>` entry, it attempts to read that file from `KO_DATA_PATH` next, which lets the changeset work much more effectively.
knative-prow-robot
pushed a commit
to knative/pkg
that referenced
this pull request
Aug 15, 2019
With ko-build/ko#73 we can link the Git ref information into images with: ``` ln -r -s .git/refs ./cmd/foo/kodata ``` If the changeset package gets a `ref: <ref>` entry, it attempts to read that file from `KO_DATA_PATH` next, which lets the changeset work much more effectively.
|
vagababov
reviewed
Aug 15, 2019
mattmoor
force-pushed
the
directory-symlinks
branch
2 times, most recently
from
5d7df96 to
23dca33
Compare
jonjohnsonjr
approved these changes
Aug 16, 2019
mattmoor
force-pushed
the
directory-symlinks
branch
from
23dca33 to
92e7077
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for properly resolving directory symlinks within kodata.
I verified that with this I can symlink
.git/refsintokodata/and (withchanges) resolve the
.git/HEADsymlink to read the appropriateref: refs/heads/...files with the commit SHA.