Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Istio 1.4 and retire 1.2 #6039

Closed
nak3 opened this issue Nov 15, 2019 · 2 comments · Fixed by #6110
Closed

Update to Istio 1.4 and retire 1.2 #6039

nak3 opened this issue Nov 15, 2019 · 2 comments · Fixed by #6110
Labels
area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/feature Well-understood/specified features, ready for coding.

Comments

@nak3
Copy link
Contributor

nak3 commented Nov 15, 2019

In what area(s)?

/area networking
/area test-and-release

Describe the feature

@nak3 nak3 added the kind/feature Well-understood/specified features, ready for coding. label Nov 15, 2019
@knative-prow-robot knative-prow-robot added area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Nov 15, 2019
@nak3
Copy link
Contributor Author

nak3 commented Nov 16, 2019

Istio 1.4 introduced Regex EngineChanges so most of E2E tests fail due to exceed the size of regex bytes in VirtualService.

e.g:

    match:
    - authority:
        regex: ^service-to-service-call-via-activator-both-disabled-rlzfmjaj\.serving-tests\.example\.com(?::\d{1,5})?$

Then, we will get an error.
{"level":"error","ts":"2019-11-16T08:13:54.839Z","logger":"istiocontroller.ingress-controller","caller":"controller/controller.go:368","msg":"Reconcile error","commit":"f961c64","knative.dev/controller":"ingress-controller","error":"failed to create VirtualService: admission webhook \"pilot.validation.istio.io\" denied the request: configuration is invalid: regex match '^service-to-service-call-via-activator-both-disabled-rlzfmjaj\\.serving-tests(\\.svc(\\.cluster\\.local)?)?(?::\\d{1,5})?$' cannot be greater than 100 bytes","stacktrace":"knative.dev/serving/vendor/knative.dev/pkg/controller.(*Impl).handleErr\n\t/home/knakayam/.go/src/knative.dev/serving/vendor/knative.dev/pkg/controller/controller.go:368\nknative.dev/serving/vendor/knative.dev/pkg/controller.(*Impl).processNextWorkItem\n\t/home/knakayam/.go/src/knative.dev/serving/vendor/knative.dev/pkg/controller/controller.go:354\nknative.dev/serving/vendor/knative.dev/pkg/controller.(*Impl).Run.func2\n\t/home/knakayam/.go/src/knative.dev/serving/vendor/knative.dev/pkg/controller/controller.go:302"}

We need to address this.

@nak3
Copy link
Contributor Author

nak3 commented Nov 18, 2019

I've opened #6058 for regex size issue.

nak3 added a commit to nak3/serving that referenced this issue Nov 27, 2019
This patch removes Istio 1.2.x code from tree.

Istio 1.4 is already included and
[testgrid](https://testgrid.knative.dev/serving#istio-1.4-mesh) is
also updated.

Fixes knative#6039
knative-prow-robot pushed a commit that referenced this issue Nov 27, 2019
This patch removes Istio 1.2.x code from tree.

Istio 1.4 is already included and
[testgrid](https://testgrid.knative.dev/serving#istio-1.4-mesh) is
also updated.

Fixes #6039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/feature Well-understood/specified features, ready for coding.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants