Start testing Istio 1.4.0 #6097
Conversation
knative-prow-robot
added
the
size/XXL
There was a problem hiding this comment.
@nak3: 0 warnings.
In response to this:
/lint
Part of #6039
Proposed Changes
- Start testing Istio 1.4.0
- Remove mTLS config (PERMISSIVE mode) due to Istio's bug issues/17837
Release Note
Istio 1.4.0 is included in Knative Serving E2E test
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
the
area/test-and-release
|
Please make change so that integration tests run with 1.4 by default. |
| @@ -0,0 +1 @@ | |||
| istio-1.4.0 | |||
There was a problem hiding this comment.
Add trailing newline:
| istio-1.4.0 | |
| istio-1.4.0 | |
| @@ -24,7 +24,7 @@ export BENCHMARK_ROOT_PATH="$GOPATH/src/knative.dev/serving/test/performance/ben | |||
| source vendor/knative.dev/test-infra/scripts/performance-tests.sh | |||
|
|
|||
| function update_knative() { | |||
| local istio_version="istio-1.2-latest" | |||
| local istio_version="istio-1.4-latest" | |||
There was a problem hiding this comment.
@chizhg I'm not 100% sure if performance test also should update to Istio 1.4 or not. If I should not update here, please let me know.
|
/lgtm Thanks a lot for making this change. In order to add a test grid we will need to ask for help from #test or file a bug to test-infra (similar to #5656) . |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, tcnghia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
Or I guess we can make a change similar to https://github.com/knative/test-infra/pull/1394/files . |
…emove 1.2 (#1559) * Enable Istio 1.4 in pull-knative-serving-istio-1.4-* test grids and remove 1.2 This is similar request with knative/serving#5656 and #1394. This PR has following changes: [x] Enable Istio 1.4 as it is already included by knative/serving#6097 [x] Remove Istio 1.2 as it will be EOL on December 13th/2019 [x] Use Istio 1.4 for pull-knative-serving-integration-tests by default * Use Istio 1.3 instead of 1.4 for pull-knative-serving-integration-tests * Fix ci/prow/config_knative.yaml * Fix cron time mismatch
/lint
Part of #6039
Proposed Changes
Release Note