Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Istio 1.4 in pull-knative-serving-istio-1.4-* test grids and remove 1.2 #1559

Merged
merged 4 commits into from
Nov 27, 2019

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Nov 26, 2019

This is similar request with knative/serving#5656 and #1394.

What this PR does, why we need it:

This PR has following two changes:

[x] Enable Istio 1.4.0 as it is already included by knative/serving#6097
[x] Remove Istio 1.2.x as it will be EOL on December 13th/2019
[x] Use Istio 1.4 1.3 for pull-knative-serving-integration-tests
/lint

Copy link
Collaborator

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nak3: 0 warnings.

In response to this:

This is similar request with knative/serving#5656 and #1394.

What this PR does, why we need it:

This PR has following two changes:

[x] Enable Istio 1.4.0 as it is already included by knative/serving#6097
[x] Remove Istio 1.2.x as it will be EOL on December 13th/2019
[x] Use Istio 1.4 for pull-knative-serving-integration-tests by default

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 26, 2019
…emove 1.2

This is similar request with knative/serving#5656 and #1394.

This PR has following changes:

[x] Enable Istio 1.4 as it is already included by knative/serving#6097
[x] Remove Istio 1.2 as it will be EOL on December 13th/2019
[x] Use Istio 1.4 for pull-knative-serving-integration-tests by default
ci/prow/config.yaml Outdated Show resolved Hide resolved
@nak3
Copy link
Contributor Author

nak3 commented Nov 26, 2019

/cc @chaodaiG
/cc @yt3liu
/cc @adrcunha
/cc @tcnghia

@chaodaiG
Copy link
Contributor

/lgtm
/approve

I'm oncall this week, will apply them

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2019
@knative-prow-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2019
@knative-prow-robot knative-prow-robot merged commit 2c4cd9d into knative:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants