-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Istio 1.4 in pull-knative-serving-istio-1.4-* test grids and remove 1.2 #1559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nak3: 0 warnings.
In response to this:
This is similar request with knative/serving#5656 and #1394.
What this PR does, why we need it:
This PR has following two changes:
[x] Enable Istio 1.4.0 as it is already included by knative/serving#6097
[x] Remove Istio 1.2.x as it will be EOL on December 13th/2019
[x] Use Istio 1.4 for pull-knative-serving-integration-tests by default/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
…emove 1.2 This is similar request with knative/serving#5656 and #1394. This PR has following changes: [x] Enable Istio 1.4 as it is already included by knative/serving#6097 [x] Remove Istio 1.2 as it will be EOL on December 13th/2019 [x] Use Istio 1.4 for pull-knative-serving-integration-tests by default
/lgtm I'm oncall this week, will apply them |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaodaiG, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is similar request with knative/serving#5656 and #1394.
What this PR does, why we need it:
This PR has following two changes:
[x] Enable Istio 1.4.0 as it is already included by knative/serving#6097
[x] Remove Istio 1.2.x as it will be EOL on December 13th/2019
[x] Use Istio
1.41.3 for pull-knative-serving-integration-tests/lint