Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BYO Revision name upgrade test #6077

Closed
dgerd opened this issue Nov 20, 2019 · 1 comment · Fixed by #6165
Closed

BYO Revision name upgrade test #6077

dgerd opened this issue Nov 20, 2019 · 1 comment · Fixed by #6165
Assignees
@dgerd
Labels
area/API API objects and controllers kind/feature Well-understood/specified features, ready for coding.

Comments

@dgerd
Copy link

dgerd commented Nov 20, 2019

In what area(s)?

/area API

/area autoscale
/area build
/area monitoring
/area networking
/area test-and-release

Describe the feature

Create an upgrade test case to catch potential problems with upgrades and BYO Revision.

Test case example:

  1. Create BYO Revision name ksvc in Knative 0.x
  2. Upgrade to Knative 0.y
  3. Attempt to update "traffic" in the ksvc
  4. The attempt should succeed.

If the attempt does not succeed it means that we likely added defaulting to a new field in our webhook. Adding a new field for defaulting will modify the RevisionTemplate spec resulting in the Revision creation failing (as Revision with that name already exists).

This issue is to get test coverage to prevent this from happening without us knowing. We will want to explore how we can handle such a case gracefully as we will likely want to add new defaults.
@dgerd dgerd added the kind/feature Well-understood/specified features, ready for coding. label Nov 20, 2019
@knative-prow-robot knative-prow-robot added area/API API objects and controllers kind/good-first-issue labels Nov 20, 2019
dgerd pushed a commit to dgerd/serving that referenced this issue Dec 5, 2019
Add upgrade test for new defaults
047c196 
This adds a new test using BYO Revision name to make sure that the
immutability contract is not violated by adding new defaults to the
Service template.

Fixes knative#6077
@dgerd
Copy link
Author

dgerd commented Dec 5, 2019

/assign @dgerd

@dgerd dgerd mentioned this issue Dec 5, 2019
Merged
knative-prow-robot pushed a commit that referenced this issue Dec 5, 2019
@knative-prow-robot
Add upgrade test for new defaults (#6165)
5c1e198 
* Add upgrade test for new defaults

This adds a new test using BYO Revision name to make sure that the
immutability contract is not violated by adding new defaults to the
Service template.

Fixes #6077

* CR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgerd dgerd

Labels
area/API API objects and controllers kind/feature Well-understood/specified features, ready for coding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add upgrade test for new defaults dgerd/serving
2 participants
@knative-prow-robot @dgerd